Skip to content

libgit2: 1.8.3 -> 1.8.4#352823

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
trofi:libgit2-update
Nov 2, 2024
Merged

libgit2: 1.8.3 -> 1.8.4#352823
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
trofi:libgit2-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 1, 2024 •
edited
Loading

Changes: https://github.com/libgit2/libgit2/releases/tag/v1.8.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
Copy link
Contributor Author

trofi commented Nov 2, 2024

Forgot to commit hash change. Should be better now.

@ofborg ofborg bot requested a review from SuperSandro2000 November 2, 2024 17:17
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 2, 2024
@SuperSandro2000 SuperSandro2000 merged commit d0c3078 into NixOS:staging Nov 2, 2024
@trofi trofi deleted the libgit2-update branch November 3, 2024 09:12
@mweinelt
Copy link
Member

mweinelt commented Nov 24, 2024 •
edited
Loading

This update broke gitstatus on x86_64-darwin:

gitstatus-x86_64-darwin> clang++  obj/tag_db.o  obj/arena.o  obj/strings.o  obj/gitstatus.o  obj/repo_cache.o  obj/repo.o  obj/thread_pool.o  obj/timer.o  obj/request.o  obj/response.o  obj/check_dir_mtime.o  obj/git.o  obj/logging.o  obj/options.o  obj/index.o  obj/dir.o -pthread  -lgit2  -o usrbin/gitstatusd
gitstatus-x86_64-darwin> ld: library not found for -lgit2
gitstatus-x86_64-darwin> clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
gitstatus-x86_64-darwin> make: *** [Makefile:25: usrbin/gitstatusd] Error 1

#358800 #358116

@trofi
Copy link
Contributor Author

trofi commented Nov 24, 2024

Looking.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2024

Please see #358116

@trofi
Copy link
Contributor Author

trofi commented Nov 25, 2024

Ended up being unrelated to libgit2 update, but something related to darwin SDK changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @mweinelt @SuperSandro2000