haskellPackages.warp: fix tests on darwin with sandbox#352778
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Nov 1, 2024
Merged
haskellPackages.warp: fix tests on darwin with sandbox#352778maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
6.topic: darwin
Member
Author
There was a problem hiding this comment.
Derp, botched the commit message.
Was thinking of warp because I ended up re-testing the sandbox vs tests interaction with it as well.
Fixed
alexfmpe
force-pushed
the
haskellPackages-snap-darwin
branch
from
9fa0ac3 to
d2b766c
Compare
sternenseemann
approved these changes
Nov 1, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #316277 (review)
Firewall doesn't seem to be relevant, only sandbox
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.