Skip to content

python3Packages.pillow-jpls: fix pypaBuildFlags#352042

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
ShamrockLee:pillow-juls-fix
Nov 3, 2024
Merged

python3Packages.pillow-jpls: fix pypaBuildFlags#352042
philiptaron merged 1 commit intoNixOS:masterfrom
ShamrockLee:pillow-juls-fix

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Oct 29, 2024 •
edited
Loading

Before this change, the pypaBuildFlags specification containing single quotes results in the following warning in the build log:

*** Configuring CMake...
CMake Warning:
  Ignoring extra path from command line:

   "'--preset=sysdeps'"

This change removes the single quotes and fixes such warnings.

Cc: @bcdarwin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 29, 2024
@ShamrockLee ShamrockLee mentioned this pull request Oct 29, 2024
Merged
13 tasks
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Oct 29, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 8 packages built:
  • python311Packages.highdicom
  • python311Packages.highdicom.dist
  • python311Packages.pillow-jpls
  • python311Packages.pillow-jpls.dist
  • python312Packages.highdicom
  • python312Packages.highdicom.dist
  • python312Packages.pillow-jpls
  • python312Packages.pillow-jpls.dist

@ofborg ofborg bot requested a review from bcdarwin October 29, 2024 08:07
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 29, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 29, 2024
@bcdarwin
Copy link
Member

bcdarwin commented Oct 29, 2024

(Note that despite this warning the --preset=sysdeps is actually being used somehow; removing it causes CMake to try to pull in dependencies via Conan instead of system libs, which of course fails in the sandbox.)

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Oct 29, 2024

(Note that despite this warning the --preset=sysdeps is actually being used somehow; removing it causes CMake to try to pull in dependencies via Conan instead of system libs, which of course fails in the sandbox.)

@bcdarwin, thank you for your approval and clarification!

Just a dumb question: What are the --config-setting flags of "PyPA build" passing? Is it command-line arguments for executing the backend executable or an extra line to add to pyproject.toml? Perusing the documentation doesn't give much insight.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 31, 2024
@philiptaron philiptaron merged commit 21ea127 into NixOS:master Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

+1 more reviewer

@bcdarwin bcdarwin bcdarwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShamrockLee @bcdarwin @wolfgangwalther @philiptaron @wegank