Skip to content

i3altlayout: 0.3 -> 1.1.2#350970

Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:i3-remove-enum34
Closed

i3altlayout: 0.3 -> 1.1.2#350970
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:i3-remove-enum34

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 24, 2024

Changelog: https://github.com/deadc0de6/i3altlayout/releases/tag/v1.1.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff mentioned this pull request Oct 24, 2024
Closed
21 tasks
@fabaff
Copy link
Member Author

fabaff commented Oct 24, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350970

x86_64-linux

✅ 2 packages built:
  • i3altlayout
  • i3altlayout.dist

@ofborg ofborg bot requested a review from magnetophon October 24, 2024 18:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 24, 2024
@magnetophon
Copy link
Member

magnetophon commented Oct 25, 2024

I tried to build a few times, but keep getting "error: cannot download i3altlayout-1.1.2.tar.gz from any mirror".

@sivizius sivizius mentioned this pull request Nov 10, 2024
Draft
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 12, 2024

It builds for me. Maintainer cc @magnetophon for testing. I suspect there aren't really many users of the package, if it can stay outdated for this long...

@magnetophon
Copy link
Member

magnetophon commented Nov 12, 2024

It builds now, but when I try to test it, I get:

[nix-shell:~/.cache/nixpkgs-review/pr-350970-5]$ ./results/i3altlayout-x86_64-linux/bin/i3altlayout
Traceback (most recent call last):
  File "/nix/store/990dnw9l9qp8jzjf3lv5cfifr2zbbnkq-i3altlayout-1.1.2/bin/.i3altlayout-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
TypeError: main() missing 2 required positional arguments: 'spath' and 'ppath'

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350970

x86_64-linux

✅ 2 packages built:
  • i3altlayout
  • i3altlayout.dist

@wolfgangwalther wolfgangwalther marked this pull request as draft February 9, 2025 12:27
@bengsparks bengsparks mentioned this pull request Feb 14, 2025
Merged
13 tasks
@fabaff fabaff closed this Mar 15, 2025
@fabaff fabaff deleted the i3-remove-enum34 branch March 15, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magnetophon magnetophon Awaiting requested review from magnetophon

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @magnetophon @FliegendeWurst