castxml: fix darwin build#350853
Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom Oct 24, 2024
paparodeo:castxml-ignore-tests
Merged
castxml: fix darwin build#350853emilazy merged 1 commit intoNixOS:staging-nextfrom paparodeo:castxml-ignore-tests
emilazy merged 1 commit intoNixOS:staging-nextfrom
paparodeo:castxml-ignore-tests
Conversation
ofborg
bot
added
6.topic: darwin
Merged
13 tasks
clang on darwin adds an `-isysroot` flag which breaks the regular expressions used in a couple tests
emilazy
approved these changes
Oct 24, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Those couple tests are doing really weird regexp matching on compiler flags so I think it’s fine to skip them on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang on darwin adds an
-isysrootflag which breaks the regular expressions used in a couple testshttps://hydra.nixos.org/build/276117682
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.