Skip to content

hplip: remove enum-compat#350778

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
fabaff:hplip-refactor
Oct 29, 2024
Merged

hplip: remove enum-compat#350778
Aleksanaa merged 1 commit intoNixOS:masterfrom
fabaff:hplip-refactor

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 23, 2024

Not needed on newer Python releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Not needed on newer Python releases
@fabaff fabaff mentioned this pull request Oct 23, 2024
21 tasks
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 23, 2024
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 23, 2024
@fabaff
Copy link
Member Author

fabaff commented Oct 23, 2024

Result of nixpkgs-review pr 350778 run on x86_64-linux 1

2 packages failed to build:
  • electrum-grs
  • electrum-grs.dist
63 packages built:
  • electrum
  • electrum.dist
  • hplip
  • hplipWithPlugin
  • hwi (python312Packages.hwi)
  • hwi.dist (python312Packages.hwi.dist)
  • iocsearcher (python312Packages.iocsearcher)
  • iocsearcher.dist (python312Packages.iocsearcher.dist)
  • python311Packages.base58
  • python311Packages.base58.dist
  • python311Packages.bases
  • python311Packages.bases.dist
  • python311Packages.bip32
  • python311Packages.bip32.dist
  • python311Packages.bitbox02
  • python311Packages.bitbox02.dist
  • python311Packages.bitcoin-utils-fork-minimal
  • python311Packages.bitcoin-utils-fork-minimal.dist
  • python311Packages.block-io
  • python311Packages.block-io.dist
  • python311Packages.hwi
  • python311Packages.hwi.dist
  • python311Packages.iocsearcher
  • python311Packages.iocsearcher.dist
  • python311Packages.ipfshttpclient
  • python311Packages.ipfshttpclient.dist
  • python311Packages.ledger-bitcoin
  • python311Packages.ledger-bitcoin.dist
  • python311Packages.py-cid
  • python311Packages.py-cid.dist
  • python311Packages.py-multiaddr
  • python311Packages.py-multiaddr.dist
  • python311Packages.py-multihash
  • python311Packages.py-multihash.dist
  • python311Packages.pytest-cid
  • python311Packages.pytest-cid.dist
  • python312Packages.base58
  • python312Packages.base58.dist
  • python312Packages.bases
  • python312Packages.bases.dist
  • python312Packages.bip32
  • python312Packages.bip32.dist
  • python312Packages.bitbox02
  • python312Packages.bitbox02.dist
  • python312Packages.bitcoin-utils-fork-minimal
  • python312Packages.bitcoin-utils-fork-minimal.dist
  • python312Packages.block-io
  • python312Packages.block-io.dist
  • python312Packages.ipfshttpclient
  • python312Packages.ipfshttpclient.dist
  • python312Packages.ledger-bitcoin
  • python312Packages.ledger-bitcoin.dist
  • python312Packages.py-cid
  • python312Packages.py-cid.dist
  • python312Packages.py-multiaddr
  • python312Packages.py-multiaddr.dist
  • python312Packages.py-multihash
  • python312Packages.py-multihash.dist
  • python312Packages.pytest-cid
  • python312Packages.pytest-cid.dist
  • sparrow
  • sparrow-unwrapped
  • zeronet-conservancy

@Pandapip1
Copy link
Member

Blocked by #349608

@ofborg ofborg bot requested a review from ttuegel October 23, 2024 22:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 23, 2024
@fabaff
Copy link
Member Author

fabaff commented Oct 24, 2024

electrum-grs is already broken on master.

@Pandapip1, why is this blocked by #349608?

@Yarny0
Copy link
Contributor

Yarny0 commented Oct 24, 2024

Tested on x86-64 with an HP LaserJet 1000, after cherry-picking the commit on top of current nixos-unstable: loads firmware into printer as soon as printer is connected via USB, prints beautiful test page. I approve!

@Pandapip1
Copy link
Member

Why is this blocked by #349608?

Borgy was failing due to fs not being able to find enum34, but it looks like it fixed itself.

@Pandapip1 Pandapip1 added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Oct 28, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 3+ This PR was reviewed and approved by three or more persons. labels Oct 29, 2024
@Aleksanaa Aleksanaa merged commit 4f10c40 into NixOS:master Oct 29, 2024
@Pandapip1 Pandapip1 added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants