Skip to content

boost1{75,77,78,79}: fix build#350658

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
paparodeo:old-boost-fixes
Oct 23, 2024
Merged

boost1{75,77,78,79}: fix build#350658
K900 merged 1 commit intoNixOS:staging-nextfrom
paparodeo:old-boost-fixes

Conversation

@paparodeo
Copy link
Contributor

condition a substituteInPlace only on boost 180 and above and add one substituteInPlace back to the only consumer, boost175.

updates change 90df0c3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

condition a substituteInPlace only on boost 180 and above and add one
substituteInPlace back to the only consumer, boost175.

updates change 90df0c3
@ofborg ofborg bot requested a review from ivan-tkatchev October 23, 2024 08:28
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 23, 2024
@K900 K900 merged commit 949b508 into NixOS:staging-next Oct 23, 2024
@paparodeo paparodeo deleted the old-boost-fixes branch October 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants