Skip to content

grpc: 1.62.1 -> 1.67.0#350432

Merged
happysalada merged 8 commits intoNixOS:stagingfrom
scraptux:update-grpc
Oct 22, 2024
Merged

grpc: 1.62.1 -> 1.67.0#350432
happysalada merged 8 commits intoNixOS:stagingfrom
scraptux:update-grpc

Conversation

@scraptux
Copy link
Contributor

@scraptux scraptux commented Oct 22, 2024

Updates grpc and all corresponding python packages to 1.67.0.
Changelog: https://github.com/grpc/grpc/releases/tag/v1.67.0

Fixes current incompatibility between packages due to differing versions. #349050

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 22, 2024
@scraptux scraptux marked this pull request as draft October 22, 2024 09:00
@scraptux scraptux marked this pull request as ready for review October 22, 2024 09:03
@scraptux scraptux marked this pull request as draft October 22, 2024 09:30
@scraptux scraptux marked this pull request as ready for review October 22, 2024 10:06
@matdibu
Copy link
Contributor

matdibu commented Oct 22, 2024

could/should this include the additional changes to python312Packages.grpcio proposed in #349727 ?

@scraptux
Copy link
Contributor Author

could/should this include the additional changes to python312Packages.grpcio proposed in #349727 ?

I was not aware of additional changes other than updating the version.
I force-pushed the other changes.

Thanks for noticing!

Copy link
Contributor

@matdibu matdibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏻

@ofborg ofborg bot requested review from LnL7, fabaff and happysalada October 22, 2024 14:30
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Oct 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2024
@happysalada happysalada merged commit 1d06a10 into NixOS:staging Oct 22, 2024
@scraptux scraptux deleted the update-grpc branch October 23, 2024 06:44
@fabaff fabaff mentioned this pull request Oct 24, 2024
21 tasks
Comment on lines -22 to 25
pname = "grpcio";
format = "setuptools";
version = "1.66.2";
version = "1.67.0";
pyproject = true;

disabled = pythonOlder "3.8";

src = fetchPypi {
inherit pname version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't update the hash for grpcio and thus I am getting:

error: hash mismatch in fixed-output derivation '/nix/store/vdhziy181llx523mhjp3r7dpc5viyhlk-grpcio-1.67.0.tar.gz.drv':
        likely URL: mirror://pypi/g/grpcio/grpcio-1.67.0.tar.gz
         specified: sha256-VjWIxYe3XDS5KLxChUjlsA6jjEaXIYGk2Ldbp+PyQjE=
            got:    sha256-4JCyVT4Noch1RJyOdQc91EFd1xyb3mpAYkD99MDuRnw=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants