splice.nix: remove toplevel {build,host,target}Platform in __splicedPackages#350299
Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom Oct 24, 2024
Merged
splice.nix: remove toplevel {build,host,target}Platform in __splicedPackages#350299Aleksanaa merged 2 commits intoNixOS:masterfrom
__splicedPackages#350299Aleksanaa merged 2 commits intoNixOS:masterfrom
Conversation
…Packages` These should have been removed in ecab3ed but were not discovered. Since these were only in `__splicedPackages` they were only available in `callPackage`, now that they are removed the entries in aliases.nix will take over. https://www.github.com/NixOS/nixpkgs/blob/e056730f13ab6ed6d8325d4343752f7f9b9bf60b/pkgs/top-level/aliases.nix#L1817
13 tasks
Mindavi
approved these changes
Oct 21, 2024
SuperSandro2000
approved these changes
Oct 21, 2024
Ericson2314
approved these changes
Oct 21, 2024
github-actions
bot
added
the
6.topic: zig
Artturin
commented
Oct 22, 2024
Artturin
force-pushed
the
splicenixplatforms
branch
from
2389b7c to
78f5a70
Compare
github-actions
bot
added
the
6.topic: flutter
Artturin
force-pushed
the
splicenixplatforms
branch
from
78f5a70 to
5588be5
Compare
RossComputerGuy
approved these changes
Oct 23, 2024
Artturin
force-pushed
the
splicenixplatforms
branch
from
5588be5 to
95c1043
Compare
github-actions
bot
added
the
6.topic: python
Member
Author
|
Ran outpaths.nix locally so now all the uses should be gone. |
ofborg
bot
added
10.rebuild-darwin: 0
Aleksanaa
approved these changes
Oct 24, 2024
13 tasks
RossComputerGuy
added a commit
to ExpidusOS/nixpkgs
that referenced
this pull request
Nov 21, 2024
PR NixOS#350299 broke Flutter's update script with how it handled getting the platform. Furthermore, the problem was made worse in the last update to Flutter which had to work around that problem. We'll just revert it for now and do a proper fix once we can figure out how to satify setting the different platforms without causing any more problems.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
PR #350299 broke Flutter's update script with how it handled getting the platform. Furthermore, the problem was made worse in the last update to Flutter which had to work around that problem. We'll just revert it for now and do a proper fix once we can figure out how to satify setting the different platforms without causing any more problems. (cherry picked from commit 1bdff91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should have been removed in ecab3ed but were not discovered.
Since these were only in
__splicedPackagesthey were only available incallPackage, now that they are removed the entries in aliases.nix will take over.https://www.github.com/NixOS/nixpkgs/blob/e056730f13ab6ed6d8325d4343752f7f9b9bf60b/pkgs/top-level/aliases.nix#L1817
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.