Skip to content

libwebsockets: fix build for ca-derivations#350137

Merged
Mindavi merged 1 commit intoNixOS:masterfrom
gador:libwebsockets-ca
Oct 28, 2024
Merged

libwebsockets: fix build for ca-derivations#350137
Mindavi merged 1 commit intoNixOS:masterfrom
gador:libwebsockets-ca

Conversation

@gador
Copy link
Member

@gador gador commented Oct 21, 2024

fixes an error when trying to build libwebsockets with a content-addressed setup.
see analog example of this fix in firefox in #297466

The corresponding error message is:

error: derivation contains an illegal reference specifier '/1gsa461ihc4japi92qld612cx5nwh1w534vbrhghmdvcxr3khdq3'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gador
libwebsockets: fix build for ca-derivations
43fccb0 
see analog example of this fix in firefox in NixOS#297466

Signed-off-by: Florian Brandes <[email protected]>
@ofborg ofborg bot requested a review from Mindavi October 21, 2024 04:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 21, 2024
@gador
Copy link
Member Author

gador commented Oct 22, 2024 •
edited
Loading

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

nixpkgs-review result

2 packages failed to build and already failed to build on hydra master:
  • janus-gateway: log was empty
  • ustreamer: log was empty
✅ 20 packages built:
  • ardour
  • ardour_7
  • chickenPackages_5.chickenEggs.mosquitto
  • collectd
  • domoticz
  • driftnet
  • ebusd
  • guacamole-server
  • kismet
  • libwebsockets
  • libwebsockets.dev
  • mosquitto
  • mosquitto.dev
  • mosquitto.lib
  • owntracks-recorder
  • seafile-client
  • seafile-shared
  • ttyd
  • ttyd.man
  • vhs

@gador
Copy link
Member Author

gador commented Oct 22, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

nixpkgs-review result

⏩ 2 packages marked as broken and skipped:
  • collectd
  • domoticz
✅ 10 packages built:
  • chickenPackages_5.chickenEggs.mosquitto
  • driftnet
  • libwebsockets
  • libwebsockets.dev
  • mosquitto
  • mosquitto.dev
  • mosquitto.lib
  • ttyd
  • ttyd.man
  • vhs

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details chickenPackages_5.chickenEggs.mosquitto-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘chickenPackages_5.chickenEggs.mosquitto-aarch64-darwin’ attribute.

driftnet-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘driftnet-aarch64-darwin’ attribute.

libwebsockets-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘libwebsockets-aarch64-darwin’ attribute.

libwebsockets.dev-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘libwebsockets.dev-aarch64-darwin’ attribute.

mosquitto-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘mosquitto-aarch64-darwin’ attribute.

mosquitto.dev-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘mosquitto.dev-aarch64-darwin’ attribute.

mosquitto.lib-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘mosquitto.lib-aarch64-darwin’ attribute.

ttyd-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘ttyd-aarch64-darwin’ attribute.

ttyd.man-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘ttyd.man-aarch64-darwin’ attribute.

vhs-aarch64-darwin:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.

error: AttrPathNotFound
Packages in ‘/nix/store/cgfnwf43hadg7y5asj9a9xln9bzk567b-nixpkgs’ do not contain ‘vhs-aarch64-darwin’ attribute.

@Mindavi Mindavi merged commit b85b73b into NixOS:master Oct 28, 2024
@gador gador mentioned this pull request Nov 8, 2024
Closed
13 tasks
gador added a commit to gador/nixpkgs that referenced this pull request Nov 9, 2024
@gador
openjdk: remove references also in CA-derivations
a2ff18c 
analog to NixOS#350137

Signed-off-by: Florian Brandes <[email protected]>
gador added a commit to gador/nixpkgs that referenced this pull request Nov 10, 2024
@gador
openjdk: remove references also in CA-derivations
53492f6 
analog to NixOS#350137

Signed-off-by: Florian Brandes <[email protected]>
@gador gador mentioned this pull request Nov 25, 2024
Closed
13 tasks
@Ericson2314
Copy link
Member

Ericson2314 commented Nov 25, 2024

Let's do #214044 instead.

@gador gador mentioned this pull request Nov 26, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mindavi Mindavi Mindavi approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gador @Ericson2314 @Mindavi