Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
jopejoe1
requested review from
K900,
Ma27,
NeQuissimus,
TredwellGit,
alyssais and
thoughtpolice
K900
reviewed
Oct 30, 2024
| , preferBuiltin ? stdenv.hostPlatform.linux-kernel.preferBuiltin or false | ||
| , kernelArch ? stdenv.hostPlatform.linuxArch | ||
| , kernelTests ? [] | ||
| , kernelTests ? {} |
Contributor
There was a problem hiding this comment.
This is technically an API break, can we maybe handle both cases for a bit?
Member
There was a problem hiding this comment.
Do we think people are passing in custom kernel tests much? I'd be surprised…
NeQuissimus
approved these changes
Oct 30, 2024
Ma27
approved these changes
Oct 31, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make linux use an attrset for tests instead of a list, as those are nicer to run with nix build and is already done by most other packages in nixpkgs see #290492.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.