python312Packages.enocean: remove enum-compat#349763
Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
Closed
python312Packages.enocean: remove enum-compat#349763fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
Member
Author
|
Result of 5 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Can you explain the rationale in the commit message? |
dotlambda
reviewed
Oct 19, 2024
| pythonRemoveDeps = [ "enum-compat" ]; | ||
|
|
||
| patches = [ | ||
| # Replace nose with pytest, https://github.com/kipe/enocean/pull/143 |
Member
There was a problem hiding this comment.
Why are you repeating the patch name?
tomodachi94
requested changes
Nov 2, 2024
Member
tomodachi94
left a comment
tomodachi94
left a comment
There was a problem hiding this comment.
A nitpick. I would also love to see @dotlambda's comments addressed.
Comment on lines
+18
to
+19
| disabled = pythonOlder "3.7"; | ||
|
|
Member
There was a problem hiding this comment.
We no longer have Python 3.7 in-tree, so this does nothing.
Suggested change
| disabled = pythonOlder "3.7"; |
Contributor
|
Superseded by #382155. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.