Skip to content

python312Packages.enum34: remove#349611

Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:enum34-remove
Closed

python312Packages.enum34: remove#349611
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:enum34-remove

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 18, 2024

enum34 is no longer needed for recent Python releases

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

enum34 is no longer needed for recent Python releases
@fabaff fabaff mentioned this pull request Oct 18, 2024
21 tasks
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 18, 2024
@nix-owners nix-owners bot requested a review from natsukium October 18, 2024 19:23
@Pandapip1
Copy link
Member

enum-compat and types-enum34 should also be removed.

@fabaff fabaff linked an issue Oct 19, 2024 that may be closed by this pull request
21 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 7, 2025
@bengsparks bengsparks self-requested a review February 7, 2025 13:11
Copy link
Contributor

@bengsparks bengsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies; I had missed that the CI had failed.
The CI failure could be fixed by rebasing; enum34 is not listed in fs/default.nix

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 9, 2025
@bengsparks bengsparks mentioned this pull request Mar 6, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove enum34

5 participants