Merged
Conversation
github-actions
bot
added
the
6.topic: python
fabaff
force-pushed
the
fs-refactor
branch
2 times, most recently
from
2747b2d to
06e9c24
Compare
ofborg
bot
added
10.rebuild-darwin: 501+
13 tasks
Member
|
This should probably target staging or staging-next |
- enable tests
Member
|
@ofborg build python312Packages.fs damn it, LLVM is not cached yet.. |
wegank
added
the
12.approvals: 1
| six | ||
| appdirs | ||
| pytz | ||
| setuptools |
Contributor
There was a problem hiding this comment.
This change breaks some downstream packages; for example attempting to build nomnatong on current master (9e09ce2) results in
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/6kb205kz8m53bbgcs1xz5890zj4b6bad-source
source root is source/src
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Traceback (most recent call last):
File "/nix/store/csrwfkw01nys8knp67xhxhdg1n11jlwc-python3.12-afdko-4.0.1/bin/.makeotf-wrapped", line 6, in <module>
from afdko.makeotf import main
File "/nix/store/csrwfkw01nys8knp67xhxhdg1n11jlwc-python3.12-afdko-4.0.1/lib/python3.12/site-packages/afdko/makeotf.py", line 13, in <module>
from afdko import convertfonttocid, fdkutils, ufotools
File "/nix/store/csrwfkw01nys8knp67xhxhdg1n11jlwc-python3.12-afdko-4.0.1/lib/python3.12/site-packages/afdko/ufotools.py", line 13, in <module>
from fontTools.ufoLib import UFOReader
File "/nix/store/1pjjzg67xrnk5m6b053k23c0n0m3s03k-python3.12-fonttools-4.54.1/lib/python3.12/site-packages/fontTools/ufoLib/__init__.py", line 42, in <module>
import fs
File "/nix/store/xbk7nbi14ihmnjxdzphjxpifs3104j3d-python3.12-fs-2.4.16/lib/python3.12/site-packages/fs/__init__.py", line 4, in <module>
__import__("pkg_resources").declare_namespace(__name__) # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'pkg_resources'
Member
There was a problem hiding this comment.
That's a bug with those packages. build-system = [ setuptools ]; should be added to those packages.
Contributor
There was a problem hiding this comment.
The stacktrace literally points to this package... the __init__.py is attempting to access a nonexistent module
Member
There was a problem hiding this comment.
Fair enough. I'll submit a patch.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.