Skip to content

python312Packages.gin-config: refactor#349602

Merged
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:gin-config-refactor
Oct 19, 2024
Merged

python312Packages.gin-config: refactor#349602
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:gin-config-refactor

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 18, 2024

  • add optional-dependencies

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- add optional-dependencies
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 18, 2024
@fabaff fabaff mentioned this pull request Oct 18, 2024
21 tasks
@fabaff
Copy link
Member Author

fabaff commented Oct 18, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349602


x86_64-linux

✅ 4 packages built:
  • python311Packages.gin-config
  • python311Packages.gin-config.dist
  • python312Packages.gin-config
  • python312Packages.gin-config.dist

@ofborg ofborg bot requested a review from jethrokuan October 18, 2024 22:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 18, 2024
@fabaff fabaff merged commit 13ac3f6 into NixOS:master Oct 19, 2024
@fabaff fabaff deleted the gin-config-refactor branch October 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant