Merged
Conversation
katexochen
added
the
6.topic: golang
github-actions
bot
added
the
8.has: documentation
35 tasks
Contributor
Author
|
Waiting for 24.11 branch-off (but can already be reviewed 😉) |
emilazy
added
the
2.status: wait for branch‐off
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
2.status: merge conflict
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
7f4543c to
a89c7ab
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
zowoq
approved these changes
Nov 15, 2024
kirillrdy
approved these changes
Nov 15, 2024
katexochen
removed
the
2.status: wait for branch‐off
wegank
added
the
12.approvals: 2
Aleksanaa
reviewed
Nov 16, 2024
13 tasks
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
a89c7ab to
dbe9266
Compare
github-actions
bot
added
6.topic: nixos
Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
dbe9266 to
f477a9c
Compare
GetPsyched
suggested changes
Nov 18, 2024
Member
GetPsyched
left a comment
GetPsyched
left a comment
There was a problem hiding this comment.
We need to account for these removed entries so that anyone heading to the old link is redirected to the new ones (or to a link hinting at why it was removed -- like release notes or some section with a callout)
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
f477a9c to
8565f33
Compare
GetPsyched
reviewed
Nov 18, 2024
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
8565f33 to
3776ca5
Compare
hsjobeki
reviewed
Nov 18, 2024
doc/redirects.json
Outdated
Contributor
There was a problem hiding this comment.
Shouldnt this redirect to the new urls?
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Yeah, that's hard to see because the identifier moved to a different line. This should be solved when the helper command is made.
EDIT: #357383
Signed-off-by: Paul Meyer <[email protected]>
As buildGoPackage was removed, it is unlikely for attributes of buildGoModule to get mixed up with those of buildGoPackage. Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
buildGoPackage/remove
branch
from
3776ca5 to
41d7136
Compare
ofborg
bot
removed
the
10.rebuild-linux: 1
wegank
removed
the
12.approvals: 2
Contributor
Author
|
can someone merge/ give their final approval? |
Aleksanaa
approved these changes
Nov 19, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318069
I reordered most of the subsection in the Go docs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.