Skip to content

gitlab-runner: 17.2.0 -> 17.7.0#349268

Closed
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/gitlab-runner
Closed

gitlab-runner: 17.2.0 -> 17.7.0#349268
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/gitlab-runner

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/gitlab-runner/versions.

meta.description for gitlab-runner is: GitLab Runner the continuous integration executor of GitLab

meta.homepage for gitlab-runner is: https://docs.gitlab.com/runner/

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 17.4.1 with grep in /nix/store/9ay68r5i3kp9ryxabcdmxq6zrfv3f7ya-gitlab-runner-17.4.1
  • found 17.4.1 in filename of file in /nix/store/9ay68r5i3kp9ryxabcdmxq6zrfv3f7ya-gitlab-runner-17.4.1

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gitlab-runner
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/9ay68r5i3kp9ryxabcdmxq6zrfv3f7ya-gitlab-runner-17.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gitlab-runner https://github.com/r-ryantm/nixpkgs/archive/33e80ed6ff17f19ed17c1cffcb52a946c8c860a9.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/33e80ed6ff17f19ed17c1cffcb52a946c8c860a9#gitlab-runner

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/9ay68r5i3kp9ryxabcdmxq6zrfv3f7ya-gitlab-runner-17.4.1
ls -la /nix/store/9ay68r5i3kp9ryxabcdmxq6zrfv3f7ya-gitlab-runner-17.4.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • gitlab-runner

Maintainer pings

cc @zimbatm @globin @krav @talyz @yayayayaka for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from globin, krav, talyz, yayayayaka and zimbatm October 17, 2024 14:51
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 17, 2024
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this if nobody objects

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2024
@Aleksanaa
Copy link
Member

Is aarch64-linux test failure something concerning?

@Aleksanaa Aleksanaa requested a review from Atemu October 28, 2024 13:16
@Atemu
Copy link
Member

Atemu commented Oct 28, 2024

Uh, huh.

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -175,5 +175,5 @@
                                   OSType: (string) (len=5) "linux",
                                -  Architecture: (string) (len=6) "x86_64",
                                +  Architecture: (string) (len=5) "arm64",
                                   Name: (string) (len=65) "registry.gitlab.com/gitlab-org/gitlab-runner/gitlab-runner-helper",
                                -  Tag: (string) (len=14) "x86_64-v17.4.1",
                                +  Tag: (string) (len=13) "arm64-v17.4.1",
                                   IsSupportingLocalImport: (bool) true,
                Test:           TestPrepare/autoset_helper_arch_and_os_on_non_windows_does_not_need_windows_kernel_version

This looks like an obvious oversight and we should disable that test on aarch64. I don't use or maintain this package, so I'll leave that up to the maintainers who should be subscribed here already.

If they don't want to support aarch64, I think it'd be fine to break support as it's a lower support tier platform but that's not my decision to make I think.

@sivizius sivizius mentioned this pull request Nov 10, 2024
13 tasks
@bkp5190 bkp5190 mentioned this pull request Nov 15, 2024
13 tasks
@wolfgangwalther wolfgangwalther marked this pull request as draft December 8, 2024 15:16
@r-ryantm r-ryantm changed the title gitlab-runner: 17.2.0 -> 17.4.1 gitlab-runner: 17.2.0 -> 17.7.0 Dec 27, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/gitlab-runner/versions.

meta.description for gitlab-runner is: GitLab Runner the continuous integration executor of GitLab

meta.homepage for gitlab-runner is: https://docs.gitlab.com/runner/

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 17.7.0 with grep in /nix/store/03ms7qczfxsx58gw06yhffw7p0cj1c44-gitlab-runner-17.7.0
  • found 17.7.0 in filename of file in /nix/store/03ms7qczfxsx58gw06yhffw7p0cj1c44-gitlab-runner-17.7.0

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gitlab-runner
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/03ms7qczfxsx58gw06yhffw7p0cj1c44-gitlab-runner-17.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gitlab-runner https://github.com/r-ryantm/nixpkgs/archive/004cddd4f850707b3c5ba40ec70aa728e28bd9b5.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/004cddd4f850707b3c5ba40ec70aa728e28bd9b5#gitlab-runner

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/03ms7qczfxsx58gw06yhffw7p0cj1c44-gitlab-runner-17.7.0
ls -la /nix/store/03ms7qczfxsx58gw06yhffw7p0cj1c44-gitlab-runner-17.7.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • gitlab-runner

Maintainer pings

cc @zimbatm @globin @krav @talyz @yayayayaka for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@r-ryantm r-ryantm force-pushed the auto-update/gitlab-runner branch from 33e80ed to 004cddd Compare December 27, 2024 19:12
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 27, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 27, 2024
@mweinelt mweinelt closed this Jan 13, 2025
@r-ryantm r-ryantm deleted the auto-update/gitlab-runner branch January 14, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants