grpc: add coments about updating related python packages for compatibility#349050
grpc: add coments about updating related python packages for compatibility#349050Aleksanaa merged 9 commits intoNixOS:masterfrom
Conversation
|
thank you! |
|
I would suggest, actually upgrading all grpc python packages at once. So the additional packages not mentioned in the comment (including your commit) would be:
Its probably also a good idea to add 'noupdate' to these packages so that r-ryantm doesn't update them individually. |
edb28e8 to
cea6d6a
Compare
Sounds like a wise thing to do. I added the python packages you mentioned to the comment and disabled auto updates for them as well as the main grpc package. Looking at the logs, r-ryantm cannot update it ultimately anyway (e.g. here). |
scraptux
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making the changes!
8af74a0 to
81eef3a
Compare
|
I decided to add a test that checks whether the related python packages have the same version as grpc. The test will fail with an error message, if any version doesn't match The test will obviously fail currently, but should pass once all packages have the same version and will help to prevent incompatibilities in the future. I don't feel to good about merging a failing test but I think it makes sense in this context. Let me know if you have concerns. |
Great idea! I believe merging now should not be a problem. Since the latest version is 1.66.2 now anyways, I think we should create a PR updating all packages once this one is merged. |
I agree that functional tests should be the desired solution, however, I am not familiar at all with the python grpc stuff and adding the tests out of the initial scope of this PR, which was just adding the comments. I crated a separate issue that can help in tracking the progress of compatibility tests: #351132 |
The grpc package should be updated together to with all related python packages to ensure compatibility.
4cd0828 to
0d7cb82
Compare
|
PR title needs to be adjusted, looks good otherwise! |
grpcshould always be updated together with related python packages to ensure compatibility. Mismatched versions have led to incompatibilities in the past: #338875Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.