Merged
Conversation
Contributor
Author
|
I rebased the patches.
Currently build of deps fails with @lukegb feel free to push on this PR if you like. :) |
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
I can confirm that the gn1924 does not build anymore due to the LFS64 patch not applying cleanly. |
stv0g
approved these changes
Oct 19, 2024
Signed-off-by: Paul Meyer <[email protected]>
Contributor
Contributor
Envoy 1.32 has added some more dependencies on rules_rust bits, so we need to support that now. In particular, for some reason, we always fail with a message about needing repinning, so we repin during the IFD phase, but we need to point rules_rust at the nixpkgs Rust toolchain, make it build the cargo-bazel tool (because the one in nixpkgs is the wrong version), and then clean up afterwards.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.