python3{11,12}Packages.nose: drop#348699
Merged
mweinelt merged 4 commits intoNixOS:masterfrom Oct 15, 2024
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udc43"
Merged
Conversation
github-actions
bot
added
6.topic: python
Scrumplex
requested changes
Oct 15, 2024
Member
Author
|
#347990 was already merged. Edit: Oh, I see, I forgot the parameter… Will open another PR to fix. |
Member
Member
Author
|
Ah, phew, it’s not quite my fault: the file changed since I started that branch locally and “removed” the nose parameter from that location by moving it further down the file, and the accursed three‐way merge decided that we had made the same change and that therefore it was fine to drop mine. #348716 fixes it. |
This was only used for testing pytest itself in `passthru.tests.pytest`. The tests weren’t passing before this, so I can’t verify if they still pass after, but looking over the source tree it would just be a matter of disabling a file at most if this breaks them further.
🎉 This package has been deprecated and unmaintained upstream for almost a decade, has required extensive patching to keep working on new Python versions, will inevitably break again with Python 3.13 dropping 2to3, is lacking a maintainer in Nixpkgs, is now unused in the tree, and has caused us all far too many headaches lately. Let’s put an end to this! Shout‐outs to mweinelt and jchv for dealing with this situation early on, pyrox0, Sigmanificient, and dotlambda for tackling a bunch of packages, and natsukium for help with reviews. I never thought this would get finished so quickly. We’ve collectively handled almost 1½ packages per day in the three months since I first opened the tracking issue, and sometimes helped move the entire ecosystem forward. Closes: NixOS#326513
Member
Author
|
Eval should hopefully be okay now. |
ofborg
bot
added
8.has: clean-up
mweinelt
approved these changes
Oct 15, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉
This package has been deprecated and unmaintained upstream for almost a decade, has required extensive patching to keep working on new Python versions, will inevitably break again with Python 3.13 dropping 2to3, is lacking a maintainer in Nixpkgs, is now unused in the tree, and has caused us all far too many headaches lately. Let’s put an end to this!
Shout‐outs to @mweinelt and @jchv for dealing with this situation early on, @pyrox0, @Sigmanificient, and @dotlambda for tackling a bunch of packages, and @natsukium for help with reviews. I never thought this would get finished so quickly. We’ve collectively handled almost 1½ packages per day in the three months since I first opened the tracking issue, and sometimes helped move the entire ecosystem forward.
Closes: #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.