Skip to content

python312Packages.premailer: drop#348580

Merged
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:drop/premailer
Oct 14, 2024
Merged

python312Packages.premailer: drop#348580
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:drop/premailer

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Oct 14, 2024

Drops python312Packages.premailer. Upstream has not made a new release in 3 years, and it is no longer compatible with the version of lxml that we ship in nixpkgs. Since it was also only an optional dependency for a single package, it has been removed.

See previous discussion in #330702 for more details.

Part of #326513.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 14, 2024
@nix-owners nix-owners bot requested a review from natsukium October 14, 2024 17:30
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 348580 run on aarch64-linux 1

@emilazy emilazy merged commit 9cc103e into NixOS:master Oct 14, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants