python312Packages.scales: use pytestCheckHook; modernize#348559
Merged
emilazy merged 2 commits intoNixOS:masterfrom Oct 14, 2024
Merged
python312Packages.scales: use pytestCheckHook; modernize#348559emilazy merged 2 commits intoNixOS:masterfrom
emilazy merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
13 tasks
Member
|
Thanks! I was thinking we could probably just drop this as it’s only used as an optional dependency for one other package, but the end result of this PR looks good to me. I don’t suppose you’d be interested in being a maintainer for the package? |
Member
Author
|
Doesn't seem like too much of a maintainence burden, I'll adopt the package. If it becomes a hassle in the future, since I don't use it and it's only an optional dependency, we can definitely revisit dropping it. |
emilazy
approved these changes
Oct 14, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Thanks!
Result of nixpkgs-review pr 348559 run on aarch64-linux 1
11 packages built:
- cassandra
- cassandra_3_0
- cassandra_3_11
- python311Packages.cassandra-driver
- python311Packages.cassandra-driver.dist
- python311Packages.scales
- python311Packages.scales.dist
- python312Packages.cassandra-driver
- python312Packages.cassandra-driver.dist
- python312Packages.scales
- python312Packages.scales.dist
ofborg
bot
added
the
11.by: package-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the work done in #334466 as part of #326513. This fixes outstanding notes about migrating to
pyprojectand modernizes the rest of the Nix code. I cherry-picked the commit from the previous PR to ensure proper authorship notices are retained.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.