azure-sdk-for-cpp: init at various versions#348202
Merged
ShamrockLee merged 8 commits intoNixOS:masterfrom Dec 8, 2025
Merged
Conversation
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
2 times, most recently
from
da846b2 to
98b6aa7
Compare
ofborg
bot
added
8.has: package (new)
cpcloud
reviewed
Oct 28, 2024
cpcloud
approved these changes
Oct 28, 2024
Contributor
cpcloud
left a comment
cpcloud
left a comment
There was a problem hiding this comment.
Given the constraints, this seems reasonable.
wegank
added
the
12.approvals: 1
FliegendeWurst
approved these changes
Nov 11, 2024
FliegendeWurst
added
the
12.approvals: 2
wegank
removed
the
12.approvals: 1
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
from
98b6aa7 to
b1cecf9
Compare
wegank
removed
the
12.approvals: 2
nixpkgs-ci
bot
added
the
12.approvals: 2
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
from
3be2ded to
0a4224c
Compare
Contributor
Author
|
I updated the source to the most recent tag of |
nixpkgs-ci
bot
removed
the
11.by: package-maintainer
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
What is your plan to keep all those version numbers in sync?
| openssl, | ||
| }: | ||
| let | ||
| macro-utils-c = stdenv.mkDerivation { |
Member
There was a problem hiding this comment.
Why are those packages inline unlike the others?
Contributor
Author
There was a problem hiding this comment.
They are not part of the SDK itself, and given that they are custom versions I opted to not expose them as regular attributes.
Contributor
Author
I plan to add a dedicated update script when there is an actual update to be done. |
13 tasks
Member
|
Contributor
Contributor
Author
|
Thanks for offering your help! |
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
2 times, most recently
from
ef01f12 to
e6e80a3
Compare
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
from
187a266 to
2f00e46
Compare
Member
|
nixpkgs vet is failing |
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
from
2f00e46 to
86ca648
Compare
ShamrockLee
reviewed
Dec 7, 2025
ShamrockLee
dismissed
their stale review
azure-sdk-for-cpp is now the package scope. The remaining propagatedBuildInputs are to workaround dependent packages expecting transient dependencies to be present according to Tobias (@tobim).
Contributor
Author
|
Anything else you want me to do so this can be merged? |
ShamrockLee
previously requested changes
Dec 7, 2025
Contributor
ShamrockLee
left a comment
ShamrockLee
left a comment
There was a problem hiding this comment.
The copyright file location is a blocker, and the rest are not.
pkgs/development/libraries/azure-sdk-for-cpp/core-tracing-opentelemetry.nix
Show resolved
Hide resolved
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
ShamrockLee
reviewed
Dec 7, 2025
Contributor
ShamrockLee
left a comment
ShamrockLee
left a comment
There was a problem hiding this comment.
Here are all the moveToOutput suggestions.
pkgs/development/libraries/azure-sdk-for-cpp/core-tracing-opentelemetry.nix
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/azure-sdk-for-cpp/messaging-eventhubs-checkpointstore-blob.nix
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/azure-sdk-for-cpp/storage-common.nix
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/azure-sdk-for-cpp/storage-files-datalake.nix
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/azure-sdk-for-cpp/storage-files-shares.nix
Outdated
Show resolved
Hide resolved
pkgs/development/libraries/azure-sdk-for-cpp/storage-queues.nix
Outdated
Show resolved
Hide resolved
It's cleaner to make the SDK a dedicated scope and force call sites to list the modules they actually need. This makes the top-level package significantly simpler.
Co-authored-by: Yueh-Shun Li <[email protected]>
Co-authored-by: Yueh-Shun Li <[email protected]>
tobim
force-pushed
the
pkgs/azure-sdk-for-cpp
branch
from
5b0e8b3 to
651d15c
Compare
Contributor
|
ShamrockLee
dismissed
their stale review
The copyright file install output issues are addressed.
ShamrockLee
approved these changes
Dec 8, 2025
Contributor
Author
|
Thanks for your help with getting it over the line. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My motivation to have this packaged is so we can enable ABFS support in
arrow-cpp.Each API client library is built in a dedicated derivation to minimize closure sizes of dependent packages.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.