Skip to content

python3{11,12}Packages.uncompyle6: use pyproject, relax spark-parser dependency, remove nose dependency#348013

Merged
emilazy merged 3 commits intoNixOS:masterfrom
emilazy:push-vnrrxuxkvpnu
Oct 13, 2024
Merged

python3{11,12}Packages.uncompyle6: use pyproject, relax spark-parser dependency, remove nose dependency#348013
emilazy merged 3 commits intoNixOS:masterfrom
emilazy:push-vnrrxuxkvpnu

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Oct 11, 2024

Upstream tests don’t use nose and we can’t run them anyway.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 11, 2024
@ofborg ofborg bot requested a review from melvyn2 October 12, 2024 05:24
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 12, 2024
@melvyn2
Copy link
Contributor

melvyn2 commented Oct 13, 2024

Result of nixpkgs-review pr 348013 run on aarch64-linux 1

4 packages built:
  • python311Packages.uncompyle6
  • python311Packages.uncompyle6.dist
  • python312Packages.uncompyle6
  • python312Packages.uncompyle6.dist

@emilazy emilazy merged commit b4f1a9a into NixOS:master Oct 13, 2024
@emilazy emilazy deleted the push-vnrrxuxkvpnu branch October 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants