python3{11,12}Packages.mhcflurry: remove nose dependency#347990
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Oct 15, 2024
Merged
python3{11,12}Packages.mhcflurry: remove nose dependency#347990GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
This package is currently broken anyway, but I have sent an untested PR upstream to migrate their tests to pytest in the hopes that it will be merged by the time we can build this again. If we fix the package before the PR is merged, hopefully we can use it as a basis for a vendored patch.
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
pyrox0
approved these changes
Oct 15, 2024
Contributor
|
13 tasks
Member
Author
|
Exciting real‐world example of three‐way merge failing to produce a conflict when it should have: #348716. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is currently broken anyway, but I have sent an untested PR upstream to migrate their tests to pytest in the hopes that it will be merged by the time we can build this again. If we fix the package before the PR is merged, hopefully we can use it as a basis for a vendored patch.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.