Skip to content

deepin.dtk: fix build on qt 6.8#347842

Merged
vcunat merged 4 commits intoNixOS:staging-nextfrom
wineee:dtk
Oct 12, 2024
Merged

deepin.dtk: fix build on qt 6.8#347842
vcunat merged 4 commits intoNixOS:staging-nextfrom
wineee:dtk

Conversation

@wineee
Copy link
Member

@wineee wineee commented Oct 11, 2024

Fix DDE build on qt 6.8, Most of the patches from archlinux maintainers

dtkgui(qt5) also need #348029

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 11, 2024
@github-actions github-actions bot added the 6.topic: LXQt The Lightweight Qt Desktop Environment label Oct 11, 2024
@ofborg ofborg bot requested a review from romildo October 11, 2024 07:47
@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 11, 2024
@wineee wineee marked this pull request as ready for review October 11, 2024 09:24
@wineee wineee requested a review from K900 October 11, 2024 09:41
@github-actions github-actions bot removed the 6.topic: LXQt The Lightweight Qt Desktop Environment label Oct 12, 2024
@wineee wineee removed the request for review from romildo October 12, 2024 02:43
@wineee wineee requested a review from NickCao October 12, 2024 03:26
@vcunat vcunat merged commit 6035854 into NixOS:staging-next Oct 12, 2024
@wineee wineee deleted the dtk branch October 12, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants