Fix codeowner workflow for branches starting with "pr"#347831
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Oct 11, 2024
Merged
Fix codeowner workflow for branches starting with "pr"#347831philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
Turns out if :<something> is passed, a local branch is updated, which can conflict if the PR branch starts with "pr". I tried to avoid that with the original code but apparently that didn't work! https://github.com/NixOS/nixpkgs/actions/runs/11284183639/job/31384967152?pr=347822 Fetching the PR commit history From https://github.com/linj-fork/nixpkgs * [new branch] pr/kanata-add-version-check -> fork/pr error: cannot lock ref 'refs/remotes/fork/pr/kanata-add-version-check': 'refs/remotes/fork/pr' exists; cannot create 'refs/remotes/fork/pr/kanata-add-version-check' ! [new branch] pr/kanata-add-version-check -> fork/pr/kanata-add-version-check (unable to update local ref) error: some local refs could not be updated; try running
3 tasks
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
Contributor
FWIW, starting with "pr/" caused failure. However, starting with "pr-" is fine. |
Member
Author
|
Yeah it looks like But yeah that's definitely a bug in the code here |
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Oct 11, 2024
jian-lin
requested changes
Oct 11, 2024
Contributor
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
Oh, this PR is merged during my review.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out if : is passed, a local branch is updated, which can conflict if the PR branch starts with "pr". I tried to avoid that with the original code but apparently that didn't work!
https://github.com/NixOS/nixpkgs/actions/runs/11284183639/job/31384967152?pr=347822
Thanks for the report, @jian-lin!
Things done
Successfully ran it locally with dry mode:
This work is sponsored by Antithesis ✨
Add a 👍 reaction to pull requests you find important.