darwin.adv_cmds: add locale data#347642
Closed
reckenrode wants to merge 2 commits intoNixOS:reckenrode/darwin-sdk-refactorfrom
Closed
darwin.adv_cmds: add locale data#347642reckenrode wants to merge 2 commits intoNixOS:reckenrode/darwin-sdk-refactorfrom
reckenrode wants to merge 2 commits intoNixOS:reckenrode/darwin-sdk-refactorfrom
Conversation
The locale data used on macOS has not been included in a source release since adv_cmds-118. Unfortunately, that data cannot be parsed by the commands in the current version of adv_cmds, and the data produced by that version is not compatible with the current libc in macOS. Since there is not a source of the actual data, this commit adds a source using the locale data from FreeBSD. It’s close but not identical to the data used on macOS.
52 tasks
Contributor
Author
|
Having locales behave like FreeBSD breaks GNU Grep’s tests. |
ofborg
bot
added
the
10.rebuild-darwin-stdenv
ofborg
bot
added
11.by: package-maintainer
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #346043 to add the missing locale data. It’s not exactly the same as the data used on macOS, but it’s close. This is being done separately in case the PR is rejected.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.