No more mass pings due to the wrong base branch [skip treewide]#347626
Closed
infinisil wants to merge 2 commits intoNixOS:masterfrom
Closed
No more mass pings due to the wrong base branch [skip treewide]#347626infinisil wants to merge 2 commits intoNixOS:masterfrom
infinisil wants to merge 2 commits intoNixOS:masterfrom
Conversation
|
The PR's base branch is set to master, but 1108 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
|
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
3 tasks
Member
|
LGTM |
Frontear
approved these changes
Oct 10, 2024
SigmaSquadron
added
12.approvals: 1
Member
|
On a serious note, awesome to see it worked! |
Member
|
Please fix the |
Member
|
LGTM (looks gore to me) |
ofborg
bot
added
the
2.status: merge conflict
infinisil
changed the title
infinisil
changed the title
infinisil
force-pushed
the
codeowners-test
branch
from
d55640f to
6e1decb
Compare
infinisil
changed the title
diff --git a/.editorconfig b/.editorconfig index 1d22591..60f8659 100644 --- a/.editorconfig +++ b/.editorconfig @@ -6,7 +6,7 @@ root = true # Unix-style newlines with a newline ending every file, utf-8 charset [*] -end_of_line = lf +end_of_line = crlf insert_final_newline = true trim_trailing_whitespace = true charset = utf-8
infinisil
force-pushed
the
codeowners-test
branch
from
6e1decb to
c061569
Compare
|
The PR's base branch is set to staging, but 15 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
nix-owners
bot
requested review from
aanderse,
adamcstephens,
adisbladis,
ajs124 and
alyssais
nix-owners
bot
requested review from
a user,
ElvishJerricco,
arianvp,
bendlas,
cole-h,
corngood,
drupol,
edolstra,
edwtjo and
emilazy
Member
Author
|
Turns out it's not possible to request more than 15 people with normal means, so it's very much impossible to mass ping people now! This isn't great though, it's fair to mass ping if the relevant files are changed legitimately, so I'll look into how this can be addressed. To avoid further notifications, let's close and lock this now though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intentional final mass ping to make a PSA to everybody who's been plagued by unnecessary mass pings for all these years, because it won't happen any longer!
This is because since recently, we're not using the GitHub-native
CODEOWNERSfile, but rather the customci/OWNERSand a smart GitHub Action workflow to check it and request reviews based on it, with the major benefits of:Please spread the news that we can freely set and change the base branch now without worrying about filling up notification inboxes, and encourage more people to add themselves as code owners 🚀
And if you spot any issues, let me know, I'll be tending to it
Original description:
Add support for Windows by changing all files to use CRLF as the file ending. Who knew it would be this simple!
This was sponsored by Antithesis and Tweag! ✨