dhcpcd: bring back enablePrivSep option, nixos/release-notes: remove duplicate note#347578
dhcpcd: bring back enablePrivSep option, nixos/release-notes: remove duplicate note#347578rnhmjoj merged 2 commits intoNixOS:staging-nextfrom
Conversation
Fix up the merge of the two dhcpcd hardening PRs (NixOS#336988 and NixOS#208780)
|
Can do revert commit a432668 ? |
|
I just brought back the build option because it may be useful on other distros. The rest... I don't see why you would use it on NixOS, given with the service running unprivileged. Am I missing something? |
|
I thought it was possible to make a default parameter. I use profile hardened and jemalloc memory allocator. The default profile uses the scudo memory allocator, which dhcpcd also works with. |
I'm not sure what you mean: |
|
But what for? Privsep is now unnecessary thanks to the systemd hardening, and if for some reason you want a different configuration you can just do |
Ok. |
|
Have you tried comparing |
|
Capabilites with use enablePrivSep: Capabilites without use enablePrivSep and run as unprivileged user: Capabilites with use enablePrivSep and run as unprivileged user: Edit: Updated the test results. |
|
I'm not sure what you're getting at, I don't see anything unexpected: systemd sets the ambient capabilities to "CAP_NET_ADMIN, CAP_NET_RAW CAP_NET_BIND_SERVICE", then inheritable = permitted = effective = ambient and everything is in the bouding set. |
|
I've updated the previous comment. |
|
I assume there is no point to this parameter then? |
|
You mean building dhcpcd with |
Yes, also had to add a few parameters to
Ok. |
A couple of fixes of #336988
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truedhcpcd.testsnix build -f nixos/release.nix manual.x86_64-linuxnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
cc: @aanderse @Izorkin @vcunat