workflows/codeowners: Dry mode for now#347538
Merged
ambroisie merged 1 commit intoNixOS:masterfrom Oct 9, 2024
Merged
Conversation
Apparently it started requesting reviews from code owners already because the DRY_MODE from the global env was overridden in the local job declaration: NixOS#347354 (comment)
github-actions
bot
added
the
6.topic: policy discussion
Member
Author
|
Merging this to avoid more reviews getting requested while figuring things out (there's a bit of a bug with it) |
This was referenced Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently it started requesting reviews from code owners already because the DRY_MODE from the global env was overridden in the local job declaration: #347354 (comment)
The intention when introduced in #336261 was to still run it in full dry mode for now.
This change fixes the behavior, making sure it always runs in dry mode.
Add a 👍 reaction to pull requests you find important.