Skip to content

pythonPackages.rtf-tokenize: init at 1.0.0#347510

Closed
Twey wants to merge 1 commit intoNixOS:masterfrom
Twey:rtf-tokenize
Closed

pythonPackages.rtf-tokenize: init at 1.0.0#347510
Twey wants to merge 1 commit intoNixOS:masterfrom
Twey:rtf-tokenize

Conversation

@Twey
Copy link
Contributor

@Twey Twey commented Oct 9, 2024

See #347354.

https://pypi.org/project/rtf-tokenize/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Twey Twey requested a review from natsukium as a code owner October 9, 2024 15:16
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 9, 2024
@Twey Twey mentioned this pull request Oct 9, 2024
13 tasks
@natsukium
Copy link
Member

see my comment #347354 (comment)

@natsukium natsukium marked this pull request as draft October 9, 2024 16:41
@Twey Twey marked this pull request as ready for review October 9, 2024 17:04
@Twey
Copy link
Contributor Author

Twey commented Oct 9, 2024

I realized I missed a pyproject on this one — I've added it and hopefully it's now ready for review. 🙂

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2024
@Twey
Copy link
Contributor Author

Twey commented Oct 13, 2024

Hi @natsukium, any further thoughts on this?

Comment on lines +20 to +23
meta = with lib; {
description = "A simple RTF tokenizer";
maintainers = with maintainers; [ twey ];
license = licenses.gpl2Plus;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
description = "A simple RTF tokenizer";
maintainers = with maintainers; [ twey ];
license = licenses.gpl2Plus;
meta = {
description = "Simple RTF tokenizer";
maintainers = with lib.maintainers; [ twey ];
license = lib.licenses.gpl2Plus;

{
lib,
fetchPypi,
python3Packages,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3Packages,
buildPythonPackage,

pythonImportsCheckHook,
pytestCheckHook,
}:
python3Packages.buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3Packages.buildPythonPackage rec {
buildPythonPackage rec {

@FliegendeWurst FliegendeWurst marked this pull request as draft January 17, 2025 08:50
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@Twey
Copy link
Contributor Author

Twey commented Jul 29, 2025

Closing in favour of #419593.

@Twey Twey closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants