gst_all_1.gstreamer: only try to link libdw if it is available#347173
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Oct 8, 2024
Merged
gst_all_1.gstreamer: only try to link libdw if it is available#347173emilazy merged 1 commit intoNixOS:stagingfrom
emilazy merged 1 commit intoNixOS:stagingfrom
Conversation
52 tasks
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Oct 8, 2024
emilazy
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while building GStreamer after #346043. Darwin provides a pkg-config compatibility file to enable libunwind on Darwin for packages that only check that. Darwin is not ELF, so libdw won’t work, but GStreamer supports a stack traces without source information on platforms not supported by libdw.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.