Merged
Conversation
OpenJFX 11 has been EOL for over a year; upstream uses OpenJFX 15 which is also EOL. According to <bisq-network/bisq#6758>, the application does not function with later versions, and has a limited remaining lifespan as there is a new major version that uses more modern versions. It looks like that version officially supports OpenJDK 22, which is also EOL, but hopefully it will work with 21 or 23. Some work was done already to package it here: <NixOS#318594>.
The derivation doesn’t support Darwin anyway, and OpenJFX 11 is EOL.
emilazy
added
1.severity: security
OpenJFX 11 reached end‐of‐life in 2023.
emilazy
force-pushed
the
push-vonqyqkkqwyo
branch
from
40f5974 to
c979637
Compare
Contributor
|
I just made another attempt at contributing Bisq 2, but the damn formatter is still getting in the way. #347160 |
thiagokokada
approved these changes
Oct 7, 2024
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
Thanks for the great work in those JDK/JFX cleanups @emilazy. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-347149-to-release-24.05 origin/release-24.05
cd .worktree/backport-347149-to-release-24.05
git switch --create backport-347149-to-release-24.05
git cherry-pick -x 9d3560b6eb2a8e23b78f80460d5f58d5f7b4f4a4 3ec78d411851ad1d2320e6c43c56595e752f0ba5 c979637f24641155d8d30511358e73483a3335c4 |
Member
Author
|
I’ll do a manual backport later.
I’m currently in the process of deduplicating the OpenJDK/OpenJFX expressions across versions, which is leading to some very interesting revelations about what all that copy‐pasting led to :) |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenJFX 11 reached end‐of‐life in 2023.
cc @emmanuelrosa – sorry about the casualty here, but we can’t ship an unsupported multimedia framework that vendors a year+ old copy of a browser engine, especially in security‐critical contexts :) Maybe you’d be interested in reviving #318594 now that the error message for the formatting check has been improved?
Result of
nixpkgs-reviewrun on x86_64-linux 11 package marked as broken and skipped:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.