libcaca: fix build on Darwin#347014
Merged
reckenrode merged 1 commit intoNixOS:masterfrom Oct 8, 2024
Merged
Conversation
libcaca tries to access a private API that is no longer available. It worked before the SDK changes because no Darwin frameworks were available in the build environment, but there is now always an SDK available, causing it to try to build Cocoa code that no longer works.
52 tasks
ofborg
bot
added
10.rebuild-darwin: 101-500
AndersonTorres
approved these changes
Oct 7, 2024
Member
|
Off-topic: which tool are you using that generates this name |
SuperSandro2000
approved these changes
Oct 7, 2024
wegank
added
12.approvals: 2
Member
It’s Jujutsu. |
Contributor
Author
|
Jujutsu can generate a branch name from the change id when you push. For small PRs like this, it’s reduces the friction to creating them if one doesn’t have to think of a name for each one. (There were 30+ follow ups I had to create to #346043.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcaca tries to access a private API that is no longer available. It worked before the SDK changes in #346043 because no Darwin frameworks were available in the build environment, but once an SDK is always available, libcaca tries to build Cocoa code that no longer works.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.