libredirect: fixes for new Darwin SDK#347012
Merged
emilazy merged 2 commits intoNixOS:stagingfrom Oct 11, 2024
Merged
Conversation
52 tasks
ofborg
bot
added
6.topic: darwin
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-rqsnonzuyyxn
branch
2 times, most recently
from
1977e01 to
c0e19d6
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
The install name should be the full path. This matches x86_64-darwin.
The location of `libSystem.tbd` depends on the SDK, making it effectively dynamic. It must be located relative to the `SDKROOT` instead of to `clang.libc`.
reckenrode
force-pushed
the
push-rqsnonzuyyxn
branch
from
c0e19d6 to
9167e4f
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
emilazy
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
emilazy
approved these changes
Oct 11, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
This package is cursed and barely used on Darwin and probably we should fix it up more or just remove it but yeah sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libredirect links without a wrapper, so it needs to specify the libc location based on
$SDROOTafter #346043 is merged.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.