python3Packages.skia-pathops: fix build on Darwin#346991
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Oct 11, 2024
Merged
python3Packages.skia-pathops: fix build on Darwin#346991emilazy merged 1 commit intoNixOS:stagingfrom
emilazy merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: python
52 tasks
ofborg
bot
added
10.rebuild-darwin: 501+
reckenrode
force-pushed
the
push-mnlymzlsuupy
branch
from
4d7332a to
ae71e0f
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
ee7fb7e to
183877a
Compare
SuperSandro2000
approved these changes
Oct 7, 2024
reckenrode
force-pushed
the
push-mnlymzlsuupy
branch
from
ae71e0f to
048cfa8
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-mnlymzlsuupy
branch
2 times, most recently
from
2a5d3e5 to
946cb79
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
The vendored version of skia-pathops needs `libtool` from cctools to build. While it could be found using `xcrun --find libtool`, Skia’s build process doesn’t use that. It tries to run `libtool` directly.
reckenrode
force-pushed
the
push-mnlymzlsuupy
branch
from
946cb79 to
86c0525
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
reckenrode
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
emilazy
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored version of skia-pathops needs
libtoolfrom cctools to build. While it could be found usingxcrun --find libtool, Skia’s build process doesn’t use that. It tries to runlibtooldirectly.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.