moltenvk: update for the new xcbuild, the new SDK, and the new version plus cleanup#346962
Merged
emilazy merged 6 commits intoNixOS:stagingfrom Oct 11, 2024
Merged
moltenvk: update for the new xcbuild, the new SDK, and the new version plus cleanup#346962emilazy merged 6 commits intoNixOS:stagingfrom
emilazy merged 6 commits intoNixOS:stagingfrom
Conversation
52 tasks
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 101-500
reckenrode
force-pushed
the
push-xrxtzvrtlpsl
branch
from
8997a87 to
98f6deb
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-xrxtzvrtlpsl
branch
2 times, most recently
from
2f17ec8 to
b968c6b
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
When using structured attrs, xcbuildHook supports schemes with spaces in their names.
MoltenVK can take advantage of newer Metal features when built with the latest Darwin SDK.
reckenrode
force-pushed
the
push-xrxtzvrtlpsl
branch
from
b968c6b to
1f0a0ab
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
reckenrode
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
emilazy
approved these changes
Oct 11, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
I’m going to trust you know what you’re doing as the package maintainer.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up MoltenVK and moves it to
pkgs/by-namein addition to updating it for the new SDK pattern in #346043.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.