man-db: fix test failure when using Darwin’s libiconv#346955
Merged
reckenrode merged 1 commit intoNixOS:stagingfrom Oct 7, 2024
Merged
man-db: fix test failure when using Darwin’s libiconv#346955reckenrode merged 1 commit intoNixOS:stagingfrom
reckenrode merged 1 commit intoNixOS:stagingfrom
Conversation
52 tasks
paparodeo
approved these changes
Oct 6, 2024
ofborg
bot
added
6.topic: darwin
man-db makes assumptions about libiconv that are not true for all libiconv implementations, which causes the test to go into an infinite loop because it never makes the progress it expects to make.
reckenrode
force-pushed
the
push-kvykxlmnunzw
branch
from
2c9988d to
ba7af30
Compare
SuperSandro2000
approved these changes
Oct 7, 2024
wegank
added
the
12.approvals: 2
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
man-db makes assumptions about libiconv that are not true for all libiconv implementations, which causes the test to go into an infinite loop because it never makes the progress it expects to make.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.