Skip to content

memstream: cross-compilation fixes#346934

Merged
veprbl merged 1 commit intoNixOS:stagingfrom
reckenrode:push-spxzyywvsqvs
Oct 7, 2024
Merged

memstream: cross-compilation fixes#346934
veprbl merged 1 commit intoNixOS:stagingfrom
reckenrode:push-spxzyywvsqvs

Conversation

@reckenrode
Copy link
Contributor

Tested with Darwin to Darwin cross-compilation using #346043. Targeting staging due to rebuilds (cctools).

  • Use $(CC) to pick up the prefixed compiler automatically; and
  • Only run check phase when the builder can execute host binaries.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. labels Oct 6, 2024
@ofborg ofborg bot requested a review from veprbl October 6, 2024 23:01
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 6, 2024
- Use `$(CC)` to pick up the prefixed compiler automatically; and
- Only run check phase when the builder can execute host binaries.
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2024
@veprbl veprbl merged commit bdff2c4 into NixOS:staging Oct 7, 2024
@reckenrode reckenrode deleted the push-spxzyywvsqvs branch October 8, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants