haskellPackages.network: fix build on x86_64-darwin#346928
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Oct 11, 2024
Merged
haskellPackages.network: fix build on x86_64-darwin#346928emilazy merged 1 commit intoNixOS:stagingfrom
emilazy merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: haskell
52 tasks
ofborg
bot
added
6.topic: darwin
reckenrode
force-pushed
the
push-umsslqrvoowu
branch
from
9ccbc70 to
123e5ee
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
ee7fb7e to
183877a
Compare
Contributor
Author
|
Same as the other PRs re: nixfmt-check. |
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
from
183877a to
1fd30e4
Compare
reckenrode
force-pushed
the
push-umsslqrvoowu
branch
2 times, most recently
from
516fa7a to
69fa119
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a240201 to
4112f1a
Compare
reckenrode
force-pushed
the
push-umsslqrvoowu
branch
from
69fa119 to
2573d49
Compare
reckenrode
force-pushed
the
reckenrode/darwin-sdk-refactor
branch
2 times, most recently
from
a1adff0 to
e3f2829
Compare
emilazy
changed the base branch from
reckenrode/darwin-sdk-refactor
to
staging
sternenseemann
approved these changes
Oct 11, 2024
angerman
reviewed
Feb 16, 2025
| __darwinAllowLocalNetworking = true; | ||
| }); | ||
|
|
||
| # network requires `IP_RECVTOS`, which was added in 10.15. |
Contributor
There was a problem hiding this comment.
$ nix build github:nixos/nixpkgs/nixos-24.11#legacyPackages.x86_64-darwin.apple-sdk_10_13
$ rg "IP_RECVTOS" result
result/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/netinet/in.h
431:#define IP_RECVTOS 27 /* bool; receive IP TOS w/dgram */
result/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/netinet/in.h
433:#define IP_RECVTOS 27 /* bool; receive IP TOS w/dgram */
Member
There was a problem hiding this comment.
This is gone in 25.05 anyway as we dropped support for versions below macOS 11. It also shouldn't matter unless the package also uses 10.14+-only APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don’t know how this is able to build currently, but it requires at least the 10.15 SDK to build on x86_64-darwin due to requiring
IP_RECVTOS.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.