nodejs: suppress failing test on x86_64-darwin#346877
Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom Oct 6, 2024
Merged
nodejs: suppress failing test on x86_64-darwin#346877emilazy merged 1 commit intoNixOS:staging-nextfrom
emilazy merged 1 commit intoNixOS:staging-nextfrom
Conversation
Contributor
Author
aduh95
approved these changes
Oct 6, 2024
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Not sure why that’s happening now, skipping the tests certainly fine by me though
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this issue while working on #346043. nodejs22 is also failing to build on staging-next #343421 with the same error. This may be a Rosetta 2 issue on macOS 15. It doesn’t happen with a native build on aarch64-darwin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.