llvmPackages.bintools: fix copy'n'paste mistake for strip#345691
llvmPackages.bintools: fix copy'n'paste mistake for strip#345691blitz wants to merge 1 commit intoNixOS:stagingfrom
Conversation
strip has been linked to llvm-objcopy instead of llvm-strip. This looks like a copy'n'paste error that worked by accident, because the underlying binary is a multi-call binary and does the right thing. Let's not rely on this and fix the link instead.
github-actions
bot
added
the
6.topic: llvm/clang
|
Looking at the original commit, this was actually on purpose. strip is explicitly mentioned. 3d1e039 I think the reasoning there actually still makes sense — it's best to mirror the behaviour of LLVM_INSTALL_BINUTILS_SYMLINKS, because that's going to be the easiest way to keep it up to date in future, and there's no point forcing a double symlink resolution, so I think we should keep it as it is. |
Fair point. For that it would have been good to leave a comment in the code, to make it obvious that this is intended behavior. But I guess it's not worth the huge rebuild just to add one. |
2 participants
strip has been linked to llvm-objcopy instead of llvm-strip. This looks like a copy'n'paste error that worked by accident, because the underlying binary is a multi-call binary and does the right thing. Let's not rely on this and fix the link instead.
I don't really have the compute to test this, so I'd be grateful if someone can do a
nixpkgs-reviewround on this!Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.