gcc13: apply default errors from gcc14#344239
Closed
alyssais wants to merge 1 commit intoNixOS:stagingfrom
Closed
Conversation
K900
approved these changes
Sep 24, 2024
Contributor
K900
left a comment
K900
left a comment
There was a problem hiding this comment.
Conceptually LGTM, implementation wise you know better than me.
emilazy
added
the
2.status: wait for branch‐off
fabianhjr
reviewed
Sep 24, 2024
Member
|
@emilazy, do we have to wait for branch-off? Probably would help nudge a lot of upgrades/patches/fixes of potential issues of packages during the ZHF for the current release. I would push to merge this before the freeze. |
Member
|
It was Alyssa’s idea to wait. It means that we will never ship a GCC 13 with warning flags inconsistent with upstream in a stable release, which seems good to me. |
alyssais
added
the
2.status: merge conflict
alyssais
force-pushed
the
gcc-errors
branch
from
67515ce to
a7a95b0
Compare
ofborg
bot
removed
the
2.status: merge conflict
Member
|
I’m ready to merge this when you are. |
We wanted to update GCC to 14. We were okay with fixing all the new errors, but ultimately it had to be rolled back due to stability issues. We don't know at what point in the 25.05 release cycle the next release will come out, so let's get ready by taking care of the new errors in advance. Once GCC 14 is the default, this should be reverted. Source: https://gcc.gnu.org/gcc-14/porting_to.html
fabianhjr
approved these changes
Nov 10, 2024
Member
|
(This doesn’t work, so we shouldn’t merge it yet. It adds the flags to |
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Nov 16, 2024
Let’s make sure both OSes get an adequate amount of compiler fun this cycle! This is a version of alyssais’s <NixOS#344239> that applies to the Linux standard environment’s compiler wrapping rather than the versioned GCC packages themselves. This is purely a transition mechanism to help us prepare for the GCC 14 update while GCC 14 itself is not yet ready for wide deployment; it will be reverted before 25.05, whether because it becomes obsolete thanks to an upgrade to GCC 14 or because we give up on GCC 14 and deicde to stick with GCC 13 with the vanilla flags. This approach means that the standard `gcc` will be wrapped correctly, unlike with the previous PR, achieving the primary goal of the change, but `gcc13` will remain as it was before. Currently, I believe the difference between the two is just bootstrapping stage stuff; it’s a bit weird to me to diverge, especially since there is a definition of `gcc` in `all-packages.nix` that looks like it ought to make them equivalent, but it may have the nice property that we can pin especially stubborn packages to GCC 13 without them getting the errors (though I am not sure if this is actually true or not, since I’m not sure how `gcc13Stdenv` actually works). One downside is that this only applies to Linux, but since this is essentially meant to be a forcing function to get us to deal with the errors early, that seems fine. Source: https://gcc.gnu.org/gcc-14/porting_to.html Co-authored-by: Alyssa Ross <[email protected]>
13 tasks
Member
Member
|
Closing in favour of #356812. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is for after branch-off.
We wanted to update GCC to 14. We were okay with fixing all the new errors, but ultimately it had to be rolled back due to stability issues.
We don't know at what point in the 25.05 release cycle the next release will come out, so let's get ready by taking care of the new errors in advance. Once GCC 14 is the default, this should be reverted.
Source: https://gcc.gnu.org/gcc-14/porting_to.html
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.