python27Packages.more-itertools: use unittestCheckHook#343822
python27Packages.more-itertools: use unittestCheckHook#343822SuperSandro2000 merged 1 commit intoNixOS:masterfrom
unittestCheckHook#343822Conversation
I thought that the Python 2 package set was entirely separate from the Python 3 one, but this appears to actually be using the main nose package. The actual code doesn’t use nose at all, and their `tox.ini` uses unittest, so let’s fix that…
|
But where is this Python 2 package being used? Can't we drop it? |
|
Hmm. It’s used by the Python 2 pytest, which is used by a bunch of other Python 2 packages. I assumed that removing it would break resholve, but surprisingly it doesn’t. Maybe it’s for GIMP plugins or something. We can’t completely remove Python 2 before resholve is dealt with; I have a plan to get resholve off Python 2 and then remove Python 2 entirely, so I’m not as enthusiastic to remove this immediately as I otherwise might be. |
Afaik resholve vendors its Python 2 packages. So that's only true about CPython 2. |
ofborg
bot
added
10.rebuild-darwin: 0
|
Fair enough. Well, I wouldn’t shed a tear if someone wanted to remove this, but in the meantime this change is trivial and removes one of the very few remaining nose dependencies, so I think it should be okay to merge. |
|
@ofborg build fahcontrol |
|
ofborg won’t build that since it’s unfree. |
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
NIXPKGS_ALLOW_INSECURE=1 nix build --impure -f. python27Packages.more-itertools works as expected
3 participants
Description of changes
I thought that the Python 2 package set was entirely separate from the Python 3 one, but this appears to actually be using the main nose package. The actual code doesn’t use nose at all, and their
tox.iniuses unittest, so let’s fix that…Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.