python3{11,12}Packages.jupyter-contrib-nbextensions: drop#343797
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Sep 23, 2024
Merged
python3{11,12}Packages.jupyter-contrib-nbextensions: drop#343797SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
This is marked as broken already because of a Jupyter Notebook upgrade, and the upstream repository hasn’t been touched in two years, so there’s little reason to try doing anything about its nose dependency. Other distributions have already dropped this package; there’s a patch from an openSUSE maintainer to migrate it off nose, but they don’t seem to package it any more.
github-actions
bot
added
6.topic: python
GaetanLepage
approved these changes
Sep 22, 2024
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM, thanks for handling this :)
Contributor
|
Result of |
ofborg
bot
added
8.has: clean-up
SuperSandro2000
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is marked as broken already because of a Jupyter Notebook upgrade, and the upstream repository hasn’t been touched in two years, so there’s little reason to try doing anything about its nose dependency. Other distributions have already dropped this package; there’s a patch from an openSUSE maintainer to migrate it off nose, but they don’t seem to package it any more.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.