Skip to content

onboard: remove unused nose dependency#343785

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
emilazy:push-lnumpnnwuktr
Sep 23, 2024
Merged

onboard: remove unused nose dependency#343785
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
emilazy:push-lnumpnnwuktr

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Sep 22, 2024

Description of changes

These tests have never been enabled since the package was added in 2017. It should be possible to get them running with pytest, but I gave up after a few minutes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

These tests have never been enabled since the package was added in
2017. It should be possible to get them running with pytest, but I
gave up after a few minutes.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 22, 2024
@SuperSandro2000 SuperSandro2000 merged commit 64b3130 into NixOS:master Sep 23, 2024
@emilazy emilazy deleted the push-lnumpnnwuktr branch September 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants