python312Packages.lockfile: Remove usage of nose; modernize#343765
Merged
emilazy merged 2 commits intoNixOS:masterfrom Sep 22, 2024
Merged
python312Packages.lockfile: Remove usage of nose; modernize#343765emilazy merged 2 commits intoNixOS:masterfrom
emilazy merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
emilazy
reviewed
Sep 22, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Funny, I was just working on this one :)
Member
|
By the way, I’m not sure if pytest tries to run tests in parallel but if it does it should definitely be disabled for these cursed tests that mutate global state. |
Member
Author
Pytest only parallelizes with |
pyrox0
force-pushed
the
denose/lockfile
branch
from
5b180b0 to
16460de
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
Result of 4 packages failed to build:
82 packages built:
I’m baffled by the regression, but it seems real at first glance. |
Member
Author
|
The ansible-runner tests seem flaky, sometimes they work(seemingly more when they're run on their own) but sometimes they don't. I don't believe it's a problem with this package. |
emilazy
approved these changes
Sep 22, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Alright, I’ll take your word for it :) I ran the build twice without success and they built fine on master, but it’s probably just luck of the draw. Merging, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.