Skip to content

python3{11,12}Packages.boto: drop#343727

Merged
drupol merged 8 commits intoNixOS:masterfrom
emilazy:push-zktksvxpkyso
Sep 22, 2024
Merged

python3{11,12}Packages.boto: drop#343727
drupol merged 8 commits intoNixOS:masterfrom
emilazy:push-zktksvxpkyso

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Sep 22, 2024

Description of changes

Boto has not seen a release since 2018, and has been officially marked as deprecated in favour of boto3 and botocore since 2021. It has required downstream patching to keep it running on newer Python versions and is broken on the new default of Python 3.12. It also requires the obsolete nose test framework that we are in the process of removing.

The few packages we carry that still require boto are in poor upstream maintenance state and some of those were already broken. The NixOps AWS plugin was the last holdout that justified keeping this package, but it is now also broken.

See the individual commits for the rationale for each individual package.

cc @fabaff (#342395)
cc @Mic92 (#327279)
cc @roberth (de facto maintainer of nixops-aws of late)
cc @veprbl (maintainer of toil)

Result of nixpkgs-review run on aarch64-linux 1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is a plugin for boto, which has been deprecated for years,
and is broken and due for removal.
No release in four years and depends on the deprecated and broken
boto package; to quote the README:

> ## Where are the maintainers ?
>
> Qubole was acquired. All the maintainers of this repo have moved
> on. Some of the employees founded ClearFeed. Others are at big data
> teams in Microsoft, Amazon et al.
Marked as broken for months, and depends on boto which has been
deprecated for years and is now also broken and due for removal.
No release in almost half a decade, no maintainer in Nixpkgs, and
the README describes it as obsolete and recommends alternatives:
<https://github.com/wal-e/wal-e/blob/978bc1926c3d46f1cb43fe7ff002037ef48c55ff/README.rst#obsolescence-notice>.
No release since 2017 and deprecated upstream; see
<kubernetes-sigs/kubespray@1869aa3#diff-a39c9f7aa728d5fa3b973bc6ba49228a>.
This package has been broken since 24.05 (`pkg_resources` error when
running `toil --help`), and hasn’t built since Python 3.12 became
the default. There have been two major upstream releases since this
package was last updated. I tried to package the newest version, which
drops the boto dependency, but unfortunately it requires obsolete
versions of other Python libraries that we no longer package. Since
it’s been broken for this long anyway and can’t be updated,
let’s drop it for now.
Boto has not seen a release since 2018, and has been officially
marked as deprecated in favour of boto3 and botocore since 2021. It
has required downstream patching to keep it running on newer Python
versions and is broken on the new default of Python 3.12. It also
requires the obsolete nose test framework that we are in the process
of removing.

The few packages we carry that still require boto are in poor upstream
maintenance state and some of those were already broken. The NixOps
AWS plugin was the last holdout that justified keeping this package,
but it is now also broken.
@emilazy emilazy requested a review from natsukium as a code owner September 22, 2024 13:59
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 22, 2024
@Mic92
Copy link
Member

Mic92 commented Sep 22, 2024

Result of nixpkgs-review pr 343727 run on x86_64-linux 1

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 22, 2024
@drupol drupol merged commit 4b9c0fa into NixOS:master Sep 22, 2024
@emilazy emilazy deleted the push-zktksvxpkyso branch September 22, 2024 20:51
@Mic92 Mic92 mentioned this pull request Sep 28, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants