emacs: respect native compilation errors by default#343388
Merged
jian-lin merged 1 commit intoNixOS:stagingfrom Sep 21, 2024
Merged
emacs: respect native compilation errors by default#343388jian-lin merged 1 commit intoNixOS:stagingfrom
jian-lin merged 1 commit intoNixOS:stagingfrom
Conversation
In other words, native compilation errors make nix build fail by default now.
AndersonTorres
approved these changes
Sep 21, 2024
ofborg
bot
added
10.rebuild-darwin: 501+
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other words, native compilation errors make nix build fail by default now.
According to the staging matrix room, the next staging cycle will starts soon. Let's make sure this PR is contained in that cycle. This PR causes about 300 build failures and I have fixes ready locally. I have sent some of those fixes. For the remaining fixes, I just need to do some cleanup before sending them. I think it is a good idea to merge this now and send fixes to staging-next later.
part of: #335442
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.